-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ support proxy between hub cluster and managed cluster #260
✨ support proxy between hub cluster and managed cluster #260
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 60.44% 60.70% +0.26%
==========================================
Files 132 128 -4
Lines 13694 13640 -54
==========================================
+ Hits 8277 8280 +3
+ Misses 4657 4596 -61
- Partials 760 764 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
5c7a0e2
to
af7299d
Compare
/approve would you also check the codecov? it seems it reduces a bit |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold Looks clear and good to me! feel free to unhold if no another update. |
Signed-off-by: Yang Le <yangle@redhat.com>
bec11b2
to
5cccebe
Compare
/lgtm |
/lgtm |
/unhold |
ac142e6
into
open-cluster-management-io:main
Summary
Allow user to configure proxy settings in bootstrap hub kubeconfig.
Related issue(s)
Fixes #